Re: [PATCHv1 1/3] arm64: dts: meson: odroid-c2: Add missing regulator linked to P5V0 regulator
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date: 2019-09-01 11:37:39
Also in:
linux-amlogic, linux-arm-kernel, lkml
On Wed, Aug 28, 2019 at 10:27 PM Anand Moon [off-list ref] wrote:
As per shematics VDDIO_AO18, VDDIO_AO3V3/VDD3V3 DDR3_1V5/DDR_VDDC:
typo: "schematics"
fixed regulator output which is supplied by P5V0. Rename vcc3v3 regulator node to vddio_ao3v3 as per shematics.
typo: "schematics" according to the schematics there's both: - VDDIO_AO3V3 - VCC3V3 (which is turned on by VDDIO_AO3V3, see [0])
quoted hunk ↗ jump to hunk
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Cc: Jerome Brunet <jbrunet@baylibre.com> Cc: Neil Armstrong <redacted> Signed-off-by: Anand Moon <redacted> --- .../boot/dts/amlogic/meson-gxbb-odroidc2.dts | 29 +++++++++++++++++-- 1 file changed, 26 insertions(+), 3 deletions(-)diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts index 792698a60a12..98e742bf44c1 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts@@ -104,11 +104,34 @@ regulator-max-microvolt = <1800000>; }; - vcc3v3: regulator-vcc3v3 { + vddio_ao1v8: regulator-vddio-ao1v8 { compatible = "regulator-fixed"; - regulator-name = "VCC3V3"; + regulator-name = "VDDIO_AO1V8"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + /* U17 RT9179GB */ + vin-supply = <&p5v0>; + }; + + vddio_ao3v3: regulator-vddio-ao3v3 { + compatible = "regulator-fixed"; + regulator-name = "VDDIO_AO3V3"; regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; + regulator-always-on; + /* U11 MP2161GJ-C499 */ + vin-supply = <&p5v0>; + }; + + vddc_ddr: regulator-vddc-ddr { + compatible = "regulator-fixed"; + regulator-name = "DDR_VDDC";
personally I would call this (along with the node name and alias) DDR3_1V5 odroid-c2_rev0.1_20150930.pdf shows that DDR3_1V5 and DDR_VDDC are both the same. however, the DDR_VDDC signal name is not used by any component in the datasheet
quoted hunk ↗ jump to hunk
+ regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <1500000>; + regulator-always-on; + /* U15 MP2161GJ-C499 */ + vin-supply = <&p5v0>; }; emmc_pwrseq: emmc-pwrseq {@@ -301,7 +324,7 @@ mmc-hs200-1_8v; mmc-pwrseq = <&emmc_pwrseq>; - vmmc-supply = <&vcc3v3>; + vmmc-supply = <&vddio_ao3v3>;
odroid-c2_rev0.1_20150930.pdf uses VCC3V3 as supply Martin