Re: [PATCH] arm64: dts: allwinner: a64: Drop PMU node
From: Robin Murphy <robin.murphy@arm.com>
Date: 2019-08-06 14:35:30
Also in:
linux-arm-kernel
On 06/08/2019 15:01, Vasily Khoruzhick wrote:
Looks like PMU in A64 is broken, it generates no interrupts at all and as result 'perf top' shows no events.
Does something like 'perf stat sleep 1' at least count cycles correctly? It could well just be that the interrupt numbers are wrong...
quoted hunk ↗ jump to hunk
Tested on Pine64-LTS. Fixes: 34a97fcc71c2 ("arm64: dts: allwinner: a64: Add PMU node") Cc: Harald Geyer <redacted> Cc: Jared D. McNeill <redacted> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 9 --------- 1 file changed, 9 deletions(-)diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index 9cc9bdde81ac..cd92f546c483 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi@@ -142,15 +142,6 @@ clock-output-names = "ext-osc32k"; }; - pmu { - compatible = "arm,cortex-a53-pmu"; - interrupts = <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 154 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>;
Cross-referencing between some random DTs in the H6 BSP I happen to have to hand and the A64 User Manual, it looks a lot like someone just forgot to subtract 32 from these to satisfy the awkward GIC binding - that wants the SPI index rather than the actual interrupt source number, which implies these should probably be 120-123 rather than 152-155. Robin.
- interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, <&cpu3>;
- };
-
psci {
compatible = "arm,psci-0.2";
method = "smc";