Re: [EXT] [PATCH v3 0/2] drm: bridge: Add NWL MIPI DSI host controller support
From: Robert Chiras <robert.chiras@nxp.com>
Date: 2019-08-28 14:30:03
Also in:
dri-devel, linux-arm-kernel, lkml
Hi Guido, I tested this on my setup and it works. My DSI panel is a little bit different and it doesn't work with this as-is, but I added some improvements on top of this, in order to be able to setup the clocks. The changes I made can arrive on top of this as improvements, of course, since it will allow this driver to dinamically set the video_pll clock for any kind of mode. So, for the whole patch-set, you can add: Tested-by: Robert Chiras <robert.chiras@nxp.com> Signed-off-by: Robert Chiras <robert.chiras@nxp.com> Best regards, Robert On Jo, 2019-08-22 at 12:44 +0200, Guido Günther wrote:
This adds initial support for the NWL MIPI DSI Host controller found on i.MX8 SoCs. It adds support for the i.MX8MQ but the same IP core can also be found on e.g. i.MX8QXP. I added the necessary hooks to support other imx8 variants but since I only have imx8mq boards to test I omitted the platform data for other SoCs. The code is based on NXPs BSP so I added Robert Chiras as Co-authored-by. Robert, if this looks sane could you add your Signed-off-by:? The most notable changes over the BSP driver are - Calculate HS mode timing from phy_configure_opts_mipi_dphy - Perform all clock setup via DT - Merge nwl-imx and nwl drivers - Add B0 silion revision quirk - become a bridge driver to hook into mxsfb (from what I read[0] DCSS, which also can drive the nwl on the imx8mq will likely not become part of imx-display-subsystem so it makes sense to make it drive a bridge for dsi as well). - Use panel_bridge to attach the panel - Use multiplex framework instead of accessing syscon directly This has been tested on a Librem 5 devkit using mxsfb with Robert's patches[1] and the rocktech-jh057n00900 panel driver on next-20190821. The DCSS can later on also act as input source too. Changes from v2: - Per review comments by Rob Herring https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fl ists.freedesktop.org%2Farchives%2Fdri-devel%2F2019- August%2F230448.html&data=02%7C01%7Crobert.chiras%40nxp.com%7C757 201f9aaa54653580e08d726edb290%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0% 7C0%7C637020674654566414&sdata=JdvAdCPGq2CTsW%2BgXgnAVltWMIfdCDQn dXSLYpnjEH8%3D&reserved=0 - bindings: - Simplify by restricting to fsl,imx8mq-nwl-dsi - document reset lines - add port@{0,1} - use a real compatible string for the panel - resets are required - Per review comments by Arnd Bergmann https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fl ists.freedesktop.org%2Farchives%2Fdri-devel%2F2019- August%2F230868.html&data=02%7C01%7Crobert.chiras%40nxp.com%7C757 201f9aaa54653580e08d726edb290%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0% 7C0%7C637020674654566414&sdata=LyJpZjQjMCe5zUdvK8CD8ETucLPxx621gW xtpAr8DM4%3D&reserved=0 - Don't access iomuxc_gpr regs directly. This allows us to drop the first patch in the series with the iomuxc_gpr field defines. - Per review comments by Laurent Pinchart - Fix wording in bindings - Add mux-controls to bindings - Don't print error message on dphy probe deferal Changes from v1: - Per review comments by Sam Ravnborg https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fl ists.freedesktop.org%2Farchives%2Fdri-devel%2F2019- July%2F228130.html&data=02%7C01%7Crobert.chiras%40nxp.com%7C75720 1f9aaa54653580e08d726edb290%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C 0%7C637020674654566414&sdata=AU2gzIwrbCdIBZenPWWYYX%2BgdX53zc2%2B SQhZbuN%2FWpU%3D&reserved=0 - Change binding docs to YAML - build: Don't always visit imx-nwl/ - build: Add header-test-y - Sort headers according to DRM convention - Use drm_display_mode instead of videmode - Per review comments by Fabio Estevam https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fl ists.freedesktop.org%2Farchives%2Fdri-devel%2F2019- July%2F228299.html&data=02%7C01%7Crobert.chiras%40nxp.com%7C75720 1f9aaa54653580e08d726edb290%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C 0%7C637020674654566414&sdata=6kpIZ6iNAQ13fMXU6sqENLwy%2FdIWL6ef8j gyas7I0CQ%3D&reserved=0 - Don't restrict build to ARCH_MXC - Drop unused includes - Drop unreachable code in imx_nwl_dsi_bridge_mode_fixup() - Drop remaining calls of dev_err() and use DRM_DEV_ERR() consistently. - Use devm_platform_ioremap_resource() - Drop devm_free_irq() in probe() error path - Use single line comments where sufficient - Use <linux/time64.h> instead of defining USEC_PER_SEC - Make input source select imx8 specific - Drop <asm/unaligned.h> inclusion (after removal of get_unaligned_le32) - Drop all EXPORT_SYMBOL_GPL() for functions used in the same module but different source files. - Drop nwl_dsi_enable_{rx,tx}_clock() by invoking clk_prepare_enable() directly - Remove pointless comment - Laurent Pinchart https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fl ists.freedesktop.org%2Farchives%2Fdri-devel%2F2019- July%2F228313.html&data=02%7C01%7Crobert.chiras%40nxp.com%7C75720 1f9aaa54653580e08d726edb290%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C 0%7C637020674654566414&sdata=tDlVGeET1CPMH9W%2FqmnePNR51vNaTKD%2F iFOoR9%2FmESc%3D&reserved=0 https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fl ists.freedesktop.org%2Farchives%2Fdri-devel%2F2019- July%2F228308.html&data=02%7C01%7Crobert.chiras%40nxp.com%7C75720 1f9aaa54653580e08d726edb290%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C 0%7C637020674654566414&sdata=NsLGAL8%2BcOC0ZZxxeoGe7VxQCgqSBEN4G3 WVGOeZpCo%3D&reserved=0 - Drop (on iMX8MQ) unused csr regmap - Use NWL_MAX_PLATFORM_CLOCKS everywhere - Drop get_unaligned_le32() usage - remove duplicate 'for the' in binding docs - Don't include unused <linux/clk-provider.h> - Don't include unused <linux/component.h> - Drop dpms_mode for tracking state, trust the drm layer on that - Use pm_runtime_put() instead of pm_runtime_put_sync() - Don't overwrite encoder type - Make imx_nwl_platform_data const - Use the reset controller API instead of open coding that platform specific part - Use <linux/bitfield.h> intead of making up our own defines - name mipi_dsi_transfer less generic: nwl_dsi_transfer - ensure clean in .remove by calling mipi_dsi_host_unregister. - prefix constants by NWL_DSI_ - properly format transfer_direction enum - simplify platform clock handling - Don't modify state in mode_fixup() and use mode_set() instead - Drop bridge detach(), already handle by nwl_dsi_host_detach() - Drop USE_*_QUIRK() macros - Drop (for now) unused clock defnitions. 'pixel' and 'bypass' clock will be used for i.MX8 SoCs but since they're unused atm drop the definitions - but keep the logic to enable/disable several clocks in place since we know we'll need it in the future. Changes from v0: - Add quirk for IMQ8MQ silicon B0 revision to not mess with the system reset controller on power down since enable() won't work otherwise. - Drop devm_free_irq() handled by the device driver core - Disable tx esc clock after the phy power down to unbreak disable/enable (unblank/blank) - Add ports to dt binding docs - Select GENERIC_PHY_MIPI_DPHY instead of GENERIC_PHY for phy_mipi_dphy_get_default_config - Select DRM_MIPI_DSI - Include drm_print.h to fix build on next-20190408 - Drop some debugging messages - Newline terminate all DRM_ printouts - Turn component driver into a drm bridge [0]: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F% 2Flists.freedesktop.org%2Farchives%2Fdri-devel%2F2019- May%2F219484.html&data=02%7C01%7Crobert.chiras%40nxp.com%7C757201 f9aaa54653580e08d726edb290%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0 %7C637020674654566414&sdata=4IVjhLy3a2XxZ4jYwDFD23D%2BvwAVAEj44hY fvvp8OpQ%3D&reserved=0 [1]: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F% 2Fpatchwork.freedesktop.org%2Fseries%2F62822%2F&data=02%7C01%7Cro bert.chiras%40nxp.com%7C757201f9aaa54653580e08d726edb290%7C686ea1d3bc 2b4c6fa92cd99c5c301635%7C0%7C0%7C637020674654566414&sdata=GueUBOc baGjWtWcMYBplL6ki2UbgaFPkQHg%2F6eReiYg%3D&reserved=0 To: David Airlie <redacted>, Daniel Vetter <redacted>, Rob Herring [off-list ref], Mark Rutland [off-list ref] , Shawn Guo [off-list ref], Sascha Hauer <s.hauer@pengutronix. de>, Pengutronix Kernel Team [off-list ref], Fabio Estevam < festevam@gmail.com>, NXP Linux Team [off-list ref], Andrzej Hajda [off-list ref], Neil Armstrong [off-list ref] , Laurent Pinchart [off-list ref], Jonas Karlman [off-list ref], Jernej Skrabec [off-list ref], Lee Jones [off-list ref], Guido Günther [off-list ref], dri-de vel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kern el@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras < robert.chiras@nxp.com>, Sam Ravnborg [off-list ref], Fabio Estevam [off-list ref], Arnd Bergmann [off-list ref] Guido Günther (2): dt-bindings: display/bridge: Add binding for NWL mipi dsi host controller drm/bridge: Add NWL MIPI DSI host controller support .../bindings/display/bridge/nwl-dsi.yaml | 155 ++++ drivers/gpu/drm/bridge/Kconfig | 2 + drivers/gpu/drm/bridge/Makefile | 1 + drivers/gpu/drm/bridge/nwl-dsi/Kconfig | 16 + drivers/gpu/drm/bridge/nwl-dsi/Makefile | 4 + drivers/gpu/drm/bridge/nwl-dsi/nwl-drv.c | 501 +++++++++++++ drivers/gpu/drm/bridge/nwl-dsi/nwl-drv.h | 65 ++ drivers/gpu/drm/bridge/nwl-dsi/nwl-dsi.c | 700 ++++++++++++++++++ drivers/gpu/drm/bridge/nwl-dsi/nwl-dsi.h | 112 +++ 9 files changed, 1556 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml create mode 100644 drivers/gpu/drm/bridge/nwl-dsi/Kconfig create mode 100644 drivers/gpu/drm/bridge/nwl-dsi/Makefile create mode 100644 drivers/gpu/drm/bridge/nwl-dsi/nwl-drv.c create mode 100644 drivers/gpu/drm/bridge/nwl-dsi/nwl-drv.h create mode 100644 drivers/gpu/drm/bridge/nwl-dsi/nwl-dsi.c create mode 100644 drivers/gpu/drm/bridge/nwl-dsi/nwl-dsi.h -- 2.20.1
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel