Thread (17 messages) 17 messages, 3 authors, 2019-08-23

Re: [PATCH v2 2/4] rtc: Add support for the MediaTek MT2712 RTC

From: Ran Bi <hidden>
Date: 2019-08-22 11:47:58
Also in: linux-arm-kernel, linux-mediatek, linux-rtc, lkml

On Thu, 2019-08-22 at 11:12 +0200, Matthias Brugger wrote:
On 01/08/2019 13:01, Ran Bi wrote:
quoted
This add support for the MediaTek MT2712 RTC. It was SoC based RTC, but
had different architecture compared with MT7622 RTC.

Signed-off-by: Ran Bi <redacted>
---
 drivers/rtc/Kconfig      |  10 +
 drivers/rtc/Makefile     |   1 +
 drivers/rtc/rtc-mt2712.c | 444 +++++++++++++++++++++++++++++++++++++++
Can't we just adjust rtc-mt7622.c (and rename it) to unify the source for both
devices. What is the difference that we need to write a driver of our own?

Regards,
Matthias
We cannot merge rtc-mt7622.c and rtc-mt2712.c together. These two rtc
hardwares have totally different design. Registers naming, registers
offset and operating method are different.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help