On 2019-08-13 18:52, Srinivas Kandagatla wrote:

Thanks for the review,

On 13/08/2019 17:03, Cezary Rojewski wrote:

quoted

On 2019-08-13 10:35, Srinivas Kandagatla wrote:

quoted

On platforms which have smart speaker amplifiers connected via
soundwire and modeled as aux devices in ASoC, in such usecases machine
driver should be able to get sdw master stream from dai so that it can
use the runtime stream to setup slave streams.

soundwire already as a set function, get function would provide more
flexibility to above configurations.

Signed-off-by: Srinivas Kandagatla <redacted>
---

quoted

quoted

+static inline void *snd_soc_dai_get_sdw_stream(struct snd_soc_dai *dai,
+                           int direction)
+{
+    if (dai->driver->ops->get_sdw_stream)
+        return dai->driver->ops->get_sdw_stream(dai, direction);
+    else
+        return ERR_PTR(-ENOTSUPP);
+}

Drop redundant else.

Not all the dai drivers would implement this function, I guess else is 
not redundant here!

--srini

quoted

Eh. By that I meant dropping "else" keyword and reducing indentation for 
"return ERR_PTR(-ENOTSUPP);"

Czarek