Re: [RFC PATCH 02/11] devfreq: exynos-bus: Extract exynos_bus_profile_init_passive()
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2019-07-24 19:08:58
Also in:
dri-devel, linux-arm-kernel, linux-pm, linux-samsung-soc, lkml
On Tue, Jul 23, 2019 at 02:20:07PM +0200, Artur Świgoń wrote:
quoted hunk ↗ jump to hunk
This patch adds a new static function, exynos_bus_profile_init_passive(), extracted from exynos_bus_probe(). Signed-off-by: Artur Świgoń <redacted> --- drivers/devfreq/exynos-bus.c | 70 +++++++++++++++++++++--------------- 1 file changed, 42 insertions(+), 28 deletions(-)diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c index d8f1efaf2d49..cf6f6cbd0f55 100644 --- a/drivers/devfreq/exynos-bus.c +++ b/drivers/devfreq/exynos-bus.c@@ -430,13 +430,51 @@ static int exynos_bus_profile_init(struct exynos_bus *bus, return ret; } +static int exynos_bus_profile_init_passive(struct exynos_bus *bus, + struct devfreq_dev_profile *profile) +{ + struct device *dev = bus->dev; + struct devfreq *parent_devfreq; + struct devfreq_passive_data *passive_data; + int ret = 0; + + /* Initialize the struct profile and governor data for passive device */ + profile->target = exynos_bus_passive_target; + profile->exit = exynos_bus_passive_exit; + + /* Get the instance of parent devfreq device */ + parent_devfreq = devfreq_get_devfreq_by_phandle(dev, 0); + if (IS_ERR(parent_devfreq)) { + ret = -EPROBE_DEFER; + goto err;
Same as in previous patch - no need for error goto. Best regards, Krzysztof _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel