Hi,

Pawel Laszczak [off-list ref] writes:

Please look at the changes in drivers/usb/common/common.c file. 
I'm going to add it as next patch to next version.
 

quoted

Pawel Laszczak [off-list ref] writes:

quoted

quoted

quoted

+void cdns3_role_stop(struct cdns3 *cdns)

quoted

quoted

quoted

+static const char *const cdns3_mode[] = {
+	[USB_DR_MODE_UNKNOWN]		= "unknown",
+	[USB_DR_MODE_OTG]		= "otg",
+	[USB_DR_MODE_HOST]		= "host",
+	[USB_DR_MODE_PERIPHERAL]	= "device",
+};

don't we have a generic version of this under usb/common ?

Yes, there is a similar array, but it is defined also as static
and there is no function for converting value to string.
There is only function for converting string to value.

right. You can add the missing interface generically instead of
duplicating the enumeration.

quoted

There is also:
[USB_DR_MODE_UNKNOWN]		= "",
Instead of:
[USB_DR_MODE_UNKNOWN]		= "unknown",

So, for USB_DR_MODE_UNKNOWN user will not see anything information.

But that's what "unknown" means :-) We don't know the information.

////// start
commit 607754c60fabc43408f4f2de82d3560c72870787 (HEAD)
Author: Pawel Laszczak [off-list ref]
Date:   Mon Jul 8 12:53:47 2019 +0200

    usb:common  Added usb_get_dr_mode_from_string and usb_dr_mode_to_string.

This would read better as:

      usb: common: Add usb_get_dr_mode_from_string and usb_dr_mode_to_string.

s/stringi/string

+ * @dr_mode: Pointer to the given dual role mode
+ *
+ * The function gets enum usb_dr_mode, and returns the correspondig string.
+ */
+const *char usb_dr_mode_to_string(const enum usb_dr_mode dr_mode)
+{
+       if (dr_mode > USB_DR_MODE_UNKNOWN || dr_mode <= USB_DR_MODE_PERIPHERAL)
+               return usb_dr_modes[dr_mode];
+
+       return usb_dr_modes[USB_DR_MODE_UNKNOWN];
+}
+EXPORT_SYMBOL_GPL(usb_dr_mode_to_string);

missing prototype in a header file.

-- 
balbi