Thread (20 messages) 20 messages, 4 authors, 2019-06-27

Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt

From: <Eugen.Hristev@microchip.com>
Date: 2019-06-25 09:14:19
Also in: linux-arm-kernel, linux-i2c, lkml


On 25.06.2019 11:55, Peter Rosin wrote:
On 2019-06-25 10:05, Eugen.Hristev@microchip.com wrote:
quoted
From: Eugen Hristev <eugen.hristev@microchip.com>

Add binding specification for analogic filter inside the i2c controller
s/analogic/the analog/
quoted
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
  Documentation/devicetree/bindings/i2c/i2c-at91.txt | 4 ++++
  1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-at91.txt b/Documentation/devicetree/bindings/i2c/i2c-at91.txt
index 8268595..20d334c 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-at91.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-at91.txt
@@ -23,6 +23,9 @@ Optional properties:
  - enable-dig-filt: Enable the built-in digital filter on the i2c lines,
    specifically required depending on the hardware PCB/board and if the
    version of the controller includes it.
+- enable-ana-filt: Enable the built-in analogic filter on the i2c lines,
+  specifically required depending on the hardware PCB/board and if the
+  version of the controller includes it.
  - Child nodes conforming to i2c bus binding
  
  Examples :
@@ -60,6 +63,7 @@ i2c0: i2c@f8034600 {
  	atmel,fifo-size = <16>;
  	i2c-sda-hold-time-ns = <336>;
  	enable-dig-filt;
+	enable-ana-filt;
Perhaps

	microchip,digital-filter;
	microchip,analog-filter;

?
Hi Peter,

Thanks for reviewing. The name of the property does not matter much to 
me, and we have properties prefixed with vendor, and some are not.

@Alexandre Belloni: which name you think it's best ?

Eugen
Cheers,
Peter
quoted
  
  	wm8731: wm8731@1a {
  		compatible = "wm8731";
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help