On Wed, 2019-06-12 at 08:42 -0300, Mauro Carvalho Chehab wrote:
quoted
Yes, we do have different error reporting facilities but I still
think
that concentrating all the error information needed in order to do
proper recovery action is the better approach here. And make that
part
of the kernel so that it is robust. Userspace can still configure
it and
so on.
If the error reporting facilities are for the same hardware "group"
(like the machine's memory controllers), I agree with you: it makes
sense to have a single driver.
If they are for completely independent hardware then implementing
as separate drivers would work equally well, with the advantage of
making easier to maintain and make it generic enough to support
different vendors using the same IP block.
Right. And if you really want a platform orchestrator for recovery in
the kenrel, it should be a separate one, that consumes data from the
individual IP block drivers that report the raw errors anyway.
But for the main case that really needs to be in the kernel, which is
DRAM, the recovery can usually be contained to the MC driver anyway.
Cheers,
Ben.