Re: [PATCH v3 08/10] staging: octeon-ethernet: support of_get_mac_address new ERR_PTR error
From: Dan Carpenter <hidden>
Date: 2019-05-03 10:37:50
Also in:
lkml, netdev
On Fri, May 03, 2019 at 09:56:05AM +0200, Petr Štetiar wrote:
There was NVMEM support added to of_get_mac_address, so it could now return NULL and ERR_PTR encoded error values, so we need to adjust all current users of of_get_mac_address to this new fact.
Which commit added NVMEM support? It hasn't hit net-next or linux-next yet... Very strange. Why would of_get_mac_address() return a mix of NULL and error pointers? In that situation, then NULL is a special kind of success like when you request feature and the feature works but it's disabled by the user. We don't want to treat it as an error but we still can't return a pointer to a feature we don't have... It's hard for me to imagine how that makes sense for getting a mac address. At the very least, this patch needs a Fixes tag. regards, dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel