Re: [PATCH v12 00/13] media: staging/imx7: add i.MX7 media driver

Hi Sakari,
On Tue 05 Feb 2019 at 11:14, Sakari Ailus wrote:

Hi Rui,

On Mon, Feb 04, 2019 at 12:00:26PM +0000, Rui Miguel Silva 
wrote:

quoted

Hi,
This series introduces the Media driver to work with the i.MX7 
SoC. it uses the
already existing imx media core drivers but since the i.MX7, 
contrary to
i.MX5/6, do not have an IPU and because of that some changes in 
the imx media
core are made along this series to make it support that case.

This patches adds CSI and MIPI-CSI2 drivers for i.MX7, along 
with several
configurations changes for this to work as a capture subsystem. 
Some bugs are
also fixed along the line. And necessary documentation.

For a more detailed view of the capture paths, pads links in 
the i.MX7 please
take a look at the documentation in PATCH 10.

The system used to test and develop this was the Warp7 board 
with an OV2680
sensor, which output format is 10-bit bayer. So, only MIPI 
interface was
tested, a scenario with an parallel input would nice to have.

Bellow goes an example of the output of the pads and links and 
the output of
v4l2-compliance testing.

The v4l-utils version used is:
v4l2-compliance SHA: 1a6c8fe9a65c26e78ba34bd4aa2df28ede7d00cb, 
32 bits

The Media Driver fail some tests but this failures are coming 
from code out of
scope of this series (imx-capture), and some from the sensor 
OV2680
but that I think not related with the sensor driver but with 
the testing and
core.

The csi and mipi-csi entities pass all compliance tests.

Cheers,
    Rui

v11->v12:
  Sakari:
    - check v4l2_ctrl_handler_free and init when exposed to 
    userspace
    - check csi_remove missing v4l2_async_notifier_unregister
    - media device unregister before ctrl_handler_free
    - GPL => GPL v2
    - Fix squash of CSI patches, issue on v11
    - add Acked-by: Sakari Ailus [off-list ref] 
    10--13
    - mipi_s_stream check for ret < 0 and call 
    pm_runtime_put_noidle
    - use __maybe_unused in pm functions
    - Extra space before labels

For patches 1, 2 and 4:

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Thanks for all your reviews, I did not add this before, because I
messed the patch order in v11.

---
Cheers,
	Rui