Re: [PATCH v5 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller
From: Rob Herring <robh@kernel.org>
Date: 2019-02-22 16:49:28
Also in:
linux-arm-kernel, linux-mediatek, linux-usb, lkml
On Tue, Feb 19, 2019 at 03:36:30PM +0800, min.guo@mediatek.com wrote:
quoted hunk ↗ jump to hunk
From: Min Guo <redacted> This adds support for MediaTek musb controller in host, peripheral and otg mode. Signed-off-by: Min Guo <redacted> --- changes in v5: suggested by Rob: 1. Modify compatible as - compatible : should be one of: "mediatek,mt-2701" ... followed by "mediatek,mtk-musb" 2. Add usb connector child node changes in v4: suggested by Sergei: 1. String alignment changes in v3: 1. no changes changes in v2: suggested by Bin: 1. Modify DRC to DRD suggested by Rob: 2. Drop the "<soc-model>-musb" in compatible 3. Remove phy-names 4. Add space after comma in clock-names --- .../devicetree/bindings/usb/mediatek,musb.txt | 54 ++++++++++++++++++++++ 1 file changed, 54 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txtdiff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt new file mode 100644 index 0000000..0632e6e --- /dev/null +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt@@ -0,0 +1,54 @@ +MediaTek musb DRD/OTG controller +------------------------------------------- + +Required properties: + - compatible : should be one of: + "mediatek,mt-2701"
That looks like a top-level SoC compatible and doesn't match the example.
+ ... + followed by "mediatek,mtk-musb" + - reg : specifies physical base address and size of + the registers + - interrupts : interrupt used by musb controller + - interrupt-names : must be "mc"
Not much point in a name when there is only 1.
+ - phys : PHY specifier for the OTG phy
+ - dr_mode : should be one of "host", "peripheral" or "otg",
+ refer to usb/generic.txt
+ - clocks : a list of phandle + clock-specifier pairs, one for
+ each entry in clock-names
+ - clock-names : must contain "main", "mcu", "univpll"
+ for clocks of controller
+
+Optional properties:
+ - power-domains : a phandle to USB power domain node to control USB's
+ MTCMOS
+
+Required child nodes:
+ usb connector node as defined in bindings/connector/usb-connector.txt
+ - extcon : for VBUS and ID pin changes detection, needed when
+ supports dual-role mode
+ - vbus-supply : reference to the VBUS regulator, needed when supports
+ dual-role mode
+
+Example:
+
+usb2: usb@11200000 {
+ compatible = "mediatek,mt2701-musb",
+ "mediatek,mtk-musb";
+ reg = <0 0x11200000 0 0x1000>;
+ interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-names = "mc";
+ phys = <&u2port2 PHY_TYPE_USB2>;
+ dr_mode = "otg";
+ clocks = <&pericfg CLK_PERI_USB0>,
+ <&pericfg CLK_PERI_USB0_MCU>,
+ <&pericfg CLK_PERI_USB_SLV>;
+ clock-names = "main","mcu","univpll";
+ power-domains = <&scpsys MT2701_POWER_DOMAIN_IFR_MSC>;
+ usb_con: connector{
+ compatible = "usb-b-connector";
+ label = "micro-USB";
+ type = "micro";
+ extcon = <&extcon_usb>;The connector node should replace 'extcon'. Add what you need here directly (e.g. id-gpios). What you add needs to be defined in usb-connector.txt.
+ vbus-supply = <&usb_vbus>; + }; +}; -- 1.9.1