Re: [PATCH v2 05/12] ARM: davinci: da850: switch to using the clocksource driver

On 08/02/19 6:04 PM, Bartosz Golaszewski wrote:

pt., 8 lut 2019 o 13:06 Sekhar Nori [off-list ref] napisał(a):

quoted

On 04/02/19 10:47 PM, Bartosz Golaszewski wrote:

quoted

+static const struct davinci_timer_cfg da850_timer_cfg = {
+     .reg = {
+             .start          = DA8XX_TIMER64P0_BASE,
+             .end            = DA8XX_TIMER64P0_BASE + SZ_4K,

SZ_4K - 1

This should have prevented watchdog timer from getting registered.

Thanks,
Sekhar

My clocksource driver doesn't call request_region() so a subsequent
devm_ioremap_resource() in the watchdog driver would still succeed. I
now fixed both the missing call and the value here.

Ah, got it. Perhaps a call to request_region() should be added to catch
issues?

Thanks,
Sekhar