Re: [PATCH v7 05/10] clk: bd718x7: Support ROHM BD70528 clk block
From: Stephen Boyd <sboyd@kernel.org>
Date: 2019-02-06 17:31:31
Also in:
linux-clk, linux-gpio, linux-pm, linux-rtc, linux-watchdog, lkml
Quoting Matti Vaittinen (2019-02-06 01:39:38)
quoted hunk ↗ jump to hunk
@@ -86,9 +87,21 @@ static int bd71837_clk_probe(struct platform_device *pdev) dev_err(&pdev->dev, "No parent clk found\n"); return -EINVAL; } - - c->reg = BD718XX_REG_OUT32K; - c->mask = BD718XX_OUT32K_EN; + switch (mfd->chip_type) { + case ROHM_CHIP_TYPE_BD71837: + case ROHM_CHIP_TYPE_BD71847: +
Nitpick: why the extra newline above?
+ c->reg = BD718XX_REG_OUT32K;
+ c->mask = BD718XX_OUT32K_EN;
+ break;
+ case ROHM_CHIP_TYPE_BD70528:
+ c->reg = BD70528_REG_CLK_OUT;
+ c->mask = BD70528_CLK_OUT_EN_MASK;
+ break;
+ default:
+ dev_err(&pdev->dev, "Unknown clk chip\n");
+ return -EINVAL;
+ }
c->mfd = mfd;
c->pdev = pdev;
c->hw.init = &init;