Re: [PATCH v5 4/5] dt-bindings: clk: exynos5433: add imem clock
flat view
From: Chanwoo Choi <cw00.choi@samsung.com>
Date: 2019-01-31 12:30:58
Also in:
linux-clk
Hi, On 19. 1. 22. 오후 6:02, Kamil Konieczny wrote:
quoted hunk ↗ jump to hunk
Add Exynos5433 DT bindings to describe imem clocks for SlimSSS (Slim Security SubSystem). Signed-off-by: Kamil Konieczny <redacted> --- include/dt-bindings/clock/exynos5433.h | 6 ++++++ 1 file changed, 6 insertions(+)diff --git a/include/dt-bindings/clock/exynos5433.h b/include/dt-bindings/clock/exynos5433.h index 87bb2b017143..52652aaabc06 100644 --- a/include/dt-bindings/clock/exynos5433.h +++ b/include/dt-bindings/clock/exynos5433.h@@ -1406,4 +1406,10 @@ #define CAM1_NR_CLK 113 +/* CMU_IMEM */ +#define CLK_ACLK_SLIMSSS 2 +#define CLK_PCLK_SLIMSSS 35 + +#define IMEM_NR_CLK 52 + #endif /* _DT_BINDINGS_CLOCK_EXYNOS5433_H */
If you define that IMEM_NR_CLK is 52, clock driver allocates the memory for 52 clocks. It cause the memory waste. IMO, you better to change it as following: #define CLK_ACLK_SLIMSSS 1 #define CLK_PCLK_SLIMSSS 2 #define IMEM_NR_CLK 3 -- Best Regards, Chanwoo Choi Samsung Electronics