Thread (10 messages) 10 messages, 2 authors, 2019-01-31

Re: [PATCH RFC 1/3] dt-bindings: hwmon: Add tachometer interrupt to pwm-fan

flat view

From: Guenter Roeck <linux@roeck-us.net>
Date: 2019-01-30 17:28:20
Also in: linux-hwmon, lkml

On Wed, Jan 30, 2019 at 04:07:05PM +0100, Stefan Wahren wrote:
quoted hunk ↗ jump to hunk
This adds the tachometer interrupt to the pwm-fan binding, which is
necessary for RPM support.

Signed-off-by: Stefan Wahren <redacted>
---
 Documentation/devicetree/bindings/hwmon/pwm-fan.txt | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
index 49ca5d8..7f69b0b 100644
--- a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
+++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
@@ -8,6 +8,9 @@ Required properties:
 
 Optional properties:
 - fan-supply    : phandle to the regulator that provides power to the fan
+- interrupts    : contains a single interrupt specifier which describes the
+                  tachometer pin output of a 2 pulse-per-revolution fan.
+                  See interrupt-controller/interrupts.txt for the format.
So a hypothetical {1,4} pulse-per-revolution fan would explicitly not be
supported ? Why ?

Guenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help