Re: [PATCH 3/4] arm64: dts: sprd: Add SC2731 charger device
From: Arnd Bergmann <arnd@arndb.de>
Date: 2019-01-30 16:46:03
Also in:
linux-arm-kernel, lkml
On Mon, Jan 21, 2019 at 8:39 AM Baolin Wang [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Add charger device node and related battery node for SC2731 PMIC. Signed-off-by: Baolin Wang <redacted> --- arch/arm64/boot/dts/sprd/sc2731.dtsi | 6 ++++++ arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 16 ++++++++++++++++ 2 files changed, 22 insertions(+)diff --git a/arch/arm64/boot/dts/sprd/sc2731.dtsi b/arch/arm64/boot/dts/sprd/sc2731.dtsi index a2edc25..b52eaf0 100644 --- a/arch/arm64/boot/dts/sprd/sc2731.dtsi +++ b/arch/arm64/boot/dts/sprd/sc2731.dtsi@@ -17,6 +17,12 @@ #address-cells = <1>; #size-cells = <0>; + charger@0 { + compatible = "sprd,sc27xx-charger", "sprd,sc2731-charger"; + reg = <0x0>; + monitored-battery = <&bat>; + };
I see some of these have already slipped through, but we should probably
fix those and not add new ones: "sprd,sc27xx-charger" is not an appropriate
compatible string, because it has a 'xx' wildcard.
What you should have instead is to list compatibility with specific older
models. You also need to have the more generic string as the last one,
not the first.
Arnd