Re: [PATCH v2 1/2] dt-bindings: Add Qualcomm USB Super-Speed PHY bindings
From: Bjorn Andersson <hidden>
Date: 2019-01-29 20:39:10
Also in:
linux-arm-kernel, linux-arm-msm, linux-usb, lkml
On Tue 29 Jan 03:35 PST 2019, Jorge Ramirez-Ortiz wrote:
Binding description for Qualcomm's Synopsys 1.0.0 super-speed PHY
SuperSpeed
quoted hunk ↗ jump to hunk
controller embedded in QCS404. Based on Sriharsha Allenki's [off-list ref] original definitions. Signed-off-by: Jorge Ramirez-Ortiz <redacted> --- .../devicetree/bindings/usb/qcom,usb-ssphy.txt | 73 ++++++++++++++++++++++ 1 file changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txtdiff --git a/Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt b/Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt new file mode 100644 index 0000000..8ef6e39 --- /dev/null +++ b/Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt@@ -0,0 +1,73 @@ +Qualcomm Synopsys 1.0.0 SS phy controller +=========================================== + +Synopsys 1.0.0 ss phy controller supports SS usb connectivity on Qualcomm +chipsets
It's based on Synopsys IP, but it's Qualcomm's version, and isn't the 1.0.0 Qualcomm's version number for this block? Also I think it "provides SuperSpeed USB connectivity on some Qualcomm platforms".
+ +Required properties: + +- compatible: + Value type: <string> + Definition: Should contain "qcom,usb-ssphy". + +- reg: + Value type: <prop-encoded-array> + Definition: USB PHY base address and length of the register map. + +- #phy-cells: + Value type: <u32> + Definition: Should be 0. See phy/phy-bindings.txt for details. + +- clocks: + Value type: <prop-encoded-array> + Definition: See clock-bindings.txt section "consumers". List of + three clock specifiers for reference, phy core and + pipe clocks. + +- clock-names: + Value type: <string> + Definition: Names of the clocks in 1-1 correspondence with the "clocks" + property. Must contain "ref", "phy" and "pipe". + +- vdd-supply: + Value type: <phandle> + Definition: phandle to the regulator VDD supply node. + +- vdda1p8-supply: + Value type: <phandle> + Definition: phandle to the regulator 1.8V supply node. + + +Optional child nodes: + +- vbus-supply: + Value type: <phandle> + Definition: phandle to the VBUS supply node. + +- resets: + Value type: <prop-encoded-array> + Definition: See reset.txt section "consumers". PHY reset specifiers + for phy core and COR resets. + +- reset-names: + Value type: <string> + Definition: Names of the resets in 1-1 correspondence with the "resets" + property. Must contain "com" and "phy".
Perhaps "Must contain both com and phy, if property is specified", to clarify that it's all or nothing. Looks good otherwise. Regards, Bjorn