On Fri, 18 Jan 2019 at 11:44, Thomas Gleixner [off-list ref] wrote:

Eddie,

On Wed, 11 Jul 2018, Eddie James wrote:

quoted

--- /dev/null
+++ b/drivers/hwmon/occ/sysfs.c

@@ -0,0 +1,188 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * OCC hwmon driver sysfs interface
+ *
+ * Copyright (C) IBM Corporation 2018
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ */

The above license information is inconsistent.

The SPDX license identifier says GPL v2 only, but the license notice says
GPL v2 or later. This is just wrong.

Please decide which one to use and please also remove the boiler plate
text. It is redundant.

See Documentation/process/license-rules.rst

Thanks Thomas.

Eddie, as IBM contributed code our preferred license is GPLv2+. Be
sure to include the copyright line in your header (I noticed some OCC
files are missing this, please audit all of your recent
contributions):

// SPDX-License-Identifier: GPL-2.0+
// Copyright IBM Corp 2019

Cheers,

Joel