Re: [PATCH v10 05/12] ARM: dts: aspeed: peci: Add PECI node
From: Joel Stanley <joel@jms.id.au>
Date: 2019-01-14 05:46:01
Also in:
lkml, openbmc
From: Joel Stanley <joel@jms.id.au>
Date: 2019-01-14 05:46:01
Also in:
lkml, openbmc
Hi Jae, On Tue, 8 Jan 2019 at 08:11, Jae Hyun Yoo [off-list ref] wrote:
This commit adds PECI bus/adapter node of AST24xx/AST25xx into aspeed-g4 and aspeed-g5.
This looks good, aside from the alias. It will go via my aspeed tree once the bindings are merged. Send them to linux-aspeed@lists.ozlabs.org at that time. In the future I suggest leaving the changes to arch/arm/boot/dts until after the bindings and driver patches have landed. They will rarely go in before hand as the bindings need to be agreed on.
serial3 = &uart4;
serial4 = &uart5;
serial5 = &vuart;
+ peci0 = &peci0;I don't think this is necessary. Can you explain why you think you need it? Cheers, Joel