Re: [PATCH 2/3] dmaengine: Extend the k3dma driver binding
From: John Stultz <hidden>
Date: 2019-01-02 18:00:31
Also in:
dmaengine, linux-arm-kernel, lkml
On Thu, Dec 27, 2018 at 10:39 PM h00249924 [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Youlin Wang <redacted> Extend the k3dma driver binding to support hisi-asp hardware variants. Signed-off-by: Youlin Wang <redacted> Signed-off-by: Tanglei Han <redacted> Cc: Vinod Koul <vkoul@kernel.org> Cc: Rob Herring <robh+dt@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> --- Documentation/devicetree/bindings/dma/k3dma.txt | 33 ++++++++++++++++++++++++- 1 file changed, 32 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/dma/k3dma.txt b/Documentation/devicetree/bindings/dma/k3dma.txt index 4945aea..cd21b82 100644 --- a/Documentation/devicetree/bindings/dma/k3dma.txt +++ b/Documentation/devicetree/bindings/dma/k3dma.txt@@ -3,7 +3,9 @@ See dma.txt first Required properties: -- compatible: Should be "hisilicon,k3-dma-1.0" +- compatible: Must be one of +- "hisilicon,k3-dma-1.0" +- "hisilicon,hisi-pcm-asp-dma-1.0" - reg: Should contain DMA registers location and length. - interrupts: Should contain one interrupt shared by all channel - #dma-cells: see dma.txt, should be 1, para number@@ -43,3 +45,32 @@ For example, i2c0 read channel request line is 18, while write channel use 19 dma-names = "rx", "tx"; }; + + + +Controller: + asp_dmac: asp_dmac@E804B000 { + compatible = "hisilicon,hisi-pcm-asp-dma-1.0"; + reg = <0x0 0xe804b000 0x0 0x1000>; + #dma-cells = <1>; + dma-channels = <16>; + dma-requests = <32>; + dma-min-chan = <0>; + dma-used-chans = <0xFFFE>; + dma-share;
Thanks for sending this out! So min-chan, used-chans and dma-share aren't in the existing binding document. So they probably should be removed from this example, or the binding document needs to be updated first. thanks -john