Thread (24 messages) 24 messages, 4 authors, 2018-12-19

Re: [PATCH v2 1/7] dt-bindings: soc: qcom: Add remote-pid binding for GLINK SMEM

From: Sibi Sankar <hidden>
Date: 2018-12-18 05:16:51
Also in: linux-arm-msm, linux-remoteproc, lkml

Hi Doug,
Thanks for the review :)

On 2018-12-18 05:29, Doug Anderson wrote:
Hi,

On Mon, Dec 17, 2018 at 2:07 AM Sibi Sankar [off-list ref] 
wrote:
quoted
Add missing qcom,remote-pid dt binding required for GLINK SMEM
which specifies the remote endpoint of the GLINK edge.

Signed-off-by: Sibi Sankar <redacted>
---
 Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt | 5 +++++
 1 file changed, 5 insertions(+)
Fixes: 2b41d6c8e696 ("dt-bindings: soc: qcom: Extend GLINK to cover 
SMEM")

quoted
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt 
b/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt
index 0b8cc533ca83..59ae603ba520 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt
@@ -21,6 +21,11 @@ edge.
        Definition: should specify the IRQ used by the remote 
processor to
                    signal this processor about communication related 
events

+- qcom,remote-pid:
+       Usage: required for glink-smem
+       Value type: <u32>
+       Definition: specifies the identfier of the remote endpoint of 
this edge
s/identfier/identifier/
missed this, will correct it in v3.
Other than the typo this seems right to me.  Feel free to add my
Reviewed-by tag when that's fixed.


-Doug
-- 
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help