On Mon, Dec 17, 2018 at 4:51 PM Bartosz Golaszewski
[off-list ref] wrote:

The driver looks good but is there any particular reason not to use
regmap for register IO?

I thought we only use regmap for MMIO when the register range is
shared (as in a system controller) so that some registers are for this,
some register or even bits in a register for some other driver, so they
need the spinlock in the regmap to protect the register range.

It is also nice for shadowing/caching of register contents I guess,
wat does this driver get from regmap MMIO?

Yours,
Linus Walleij