Re: [PATCH v1 2/4] arm64: dts: qcom: msm8996: Fix QMP PHY #clock-cells
From: Vivek Gautam <hidden>
Date: 2018-12-07 08:32:22
Also in:
linux-arm-msm, lkml
On Fri, Nov 30, 2018 at 3:45 AM Evan Green [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Move #clock-cells into the child node and set it to 0 to conform to the proper binding specification. Signed-off-by: Evan Green <redacted> --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 13bb96444df00..4af740ca0880f 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi@@ -767,7 +767,6 @@ phy@34000 { compatible = "qcom,msm8996-qmp-pcie-phy"; reg = <0x34000 0x488>; - #clock-cells = <1>; #address-cells = <1>; #size-cells = <1>; ranges;@@ -790,6 +789,7 @@ reg = <0x035000 0x130>, <0x035200 0x200>, <0x035400 0x1dc>; + #clock-cells = <0>; #phy-cells = <0>; clock-output-names = "pcie_0_pipe_clk_src";@@ -803,6 +803,7 @@ reg = <0x036000 0x130>, <0x036200 0x200>, <0x036400 0x1dc>; + #clock-cells = <0>; #phy-cells = <0>; clock-output-names = "pcie_1_pipe_clk_src";@@ -816,6 +817,7 @@ reg = <0x037000 0x130>, <0x037200 0x200>, <0x037400 0x1dc>; + #clock-cells = <0>; #phy-cells = <0>; clock-output-names = "pcie_2_pipe_clk_src";@@ -829,7 +831,6 @@ phy@7410000 { compatible = "qcom,msm8996-qmp-usb3-phy"; reg = <0x7410000 0x1c4>; - #clock-cells = <1>; #address-cells = <1>; #size-cells = <1>; ranges;@@ -851,6 +852,7 @@ reg = <0x7410200 0x200>, <0x7410400 0x130>, <0x7410600 0x1a8>; + #clock-cells = <0>; #phy-cells = <0>; clock-output-names = "usb3_phy_pipe_clk_src"; --2.18.1
Tested on db820c [1] Tested-by: Vivek Gautam <redacted> [1] https://github.com/vivekgautam1/linux/tree/origin/v4.20-rc5/db820c BRs Vivek -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation