Thread (4 messages) 4 messages, 4 authors, 2018-12-14

Re: [PATCH] pinctrl: Use of_node_name_eq for node name comparisons

From: Tomasz Figa <hidden>
Date: 2018-12-06 05:25:34
Also in: linux-arm-kernel, linux-gpio, linux-samsung-soc, lkml

2018年12月5日(水) 11:51 Rob Herring [off-list ref]:
quoted hunk ↗ jump to hunk
Convert string compares of DT node names to use of_node_name_eq helper
instead. This removes direct access to the node name pointer.

Cc: Tomasz Figa <redacted>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Linus Walleij <redacted>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
 drivers/pinctrl/samsung/pinctrl-samsung.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
index ee6ee2338606..de0477bb469d 100644
--- a/drivers/pinctrl/samsung/pinctrl-samsung.c
+++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
@@ -1071,7 +1071,7 @@ samsung_pinctrl_get_soc_data(struct samsung_pinctrl_drv_data *d,
                        continue;
                bank = d->pin_banks;
                for (i = 0; i < d->nr_banks; ++i, ++bank) {
-                       if (!strcmp(bank->name, np->name)) {
+                       if (of_node_name_eq(np, bank->name)) {
                                bank->of_node = np;
                                break;
                        }
--
2.19.1
Reviewed-by: Tomasz Figa <redacted>

Best regards,
Tomasz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help