Thread (17 messages) 17 messages, 3 authors, 2018-11-19

RE: [PATCH 2/3] phy: renesas: rcar-gen3-usb2: Add support for R7S9210

From: Chris Brandt <Chris.Brandt@renesas.com>
Date: 2018-11-19 18:45:06
Also in: linux-clk, linux-renesas-soc

Hi Shimodaさん

From: Yoshihiro Shimoda
Sent: Monday, November 19, 2018 3:58 AM
And I read Figure 32.1 of the RZ/A2 documentation and I wonder if we need
to release
USBCTR.PLL_RST even if we use USB peripheral mode.
I will ask the RZ/A2 design team to confirm.

If this setting is required, I think we should use your suggestion:

From: Yoshihiro Shimoda
Sent: Thursday, November 15, 2018 4:20 AM
So, I have an idea to set the default mode by using "dr_mode" property,
instead of hardcoded. Since the driver already has such a function,
we can reuse rcar_gen3_device_recognition() to set the default value.
To achieve that, we need to modify the following though.
 - Don't enable "is_otg_channel".
 - Don't call rcar_gen3_enable_vbus_ctrl() to avoid ADPCTRL register
   because RZ/A2 doesn't have it.
 - Don't need to call rcar_gen3_set_linectrl to avoid LINECTRL1 register
   because RZ/A2 doesn't seem to need the setting on host mode.

Chris
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help