Hi,

On Mon, Nov 26, 2018 at 10:57 PM Stephen Boyd [off-list ref] wrote:

quoted

quoted

+               videocc: clock-controller@ab00000 {
+                       compatible = "qcom,sdm845-videocc";
+                       reg = <0xab00000 0x10000>;
+                       #clock-cells = <1>;
+                       #power-domain-cells = <1>;

Any reason not to include "#reset-cells = <1>;" here?  The bindings
list it as optional but I see no reason why we should leave it off.
The file "include/dt-bindings/clock/qcom,videocc-sdm845.h" seems to
include some #defines for resets.  Even though the driver doesn't seem
like it supports it yet, it still should be fine to list it here.

We should update the binding to make it a required property. It doesn't
make any sense why that property would be optional given that the
hardware either has support for resets or it doesn't.

Patch sent for the bindings change.

https://lkml.kernel.org/r/20181127192443.136158-1-dianders@chromium.org