Hello,

On Tue, Nov 27, 2018 at 08:52:26AM +0100, Maxime Ripard wrote:

On Mon, Nov 26, 2018 at 12:18:59AM +0800, Hao Zhang wrote:

quoted

+  - clocks: From common clock binding, handle to the parent clock.
+  - clock-names: Must contain the clock names described just above.

[...]

You seem to have used mux-0 and mux-1 for the clock names. I guess we
don't have to use a name there, we can simply use the position to find
out (as long as it's documented in the binding)

I also wondered if the driver relies on the fact that the second clock
is the faster running one. Is this sensible?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |