Re: [RFC PATCH v2 04/14] dt-bindings: interrupt-controller: Add suniv interrupt-controller
From: Maxime Ripard <hidden>
Date: 2018-11-20 08:44:14
Also in:
linux-arm-kernel, linux-clk, linux-gpio, lkml
Hi, On Sun, Nov 18, 2018 at 05:17:03PM +0300, Mesih Kilinc wrote:
quoted hunk ↗ jump to hunk
Add compatible string for Alwinner suniv F1C100s SoC interrupt controller which is stripped version of sun4i Signed-off-by: Mesih Kilinc <redacted> --- .../devicetree/bindings/interrupt-controller/allwinner,sun4i-ic.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-ic.txt b/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-ic.txt index b290ca1..e04ddb4 100644 --- a/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-ic.txt +++ b/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-ic.txt@@ -2,7 +2,10 @@ Allwinner Sunxi Interrupt Controller Required properties: -- compatible : should be "allwinner,sun4i-a10-ic" +- compatible: should be "allwinner,<soc-familiy>-<soc-name>-ic" to identify
There's no need to define the pattern, just list the compatibles supported. Otherwise, you give the idea that all the combinations are supported, and they aren't. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com