Re: [PATCH v4 03/26] clk: sunxi-ng: Add check for maximum rate to NKM PLLs
From: Maxime Ripard <hidden>
Date: 2018-11-13 13:27:12
Also in:
dri-devel, linux-arm-kernel, linux-clk, lkml
On Tue, Nov 13, 2018 at 04:46:10PM +0530, Jagan Teki wrote:
Some NKM PLLs, frequency can be set above PLL working range. Add a constraint for maximum supported rate. This way, drivers can specify which is maximum allowed rate for PLL. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> Acked-by: Stephen Boyd <sboyd@kernel.org>
As Vasily reported on a previous version, this should be squashed with the patch 2.
quoted hunk ↗ jump to hunk
--- drivers/clk/sunxi-ng/ccu_nkm.c | 3 +++ drivers/clk/sunxi-ng/ccu_nkm.h | 1 + 2 files changed, 4 insertions(+)diff --git a/drivers/clk/sunxi-ng/ccu_nkm.c b/drivers/clk/sunxi-ng/ccu_nkm.c index 6b5ad990f802..b8b66cdd30bf 100644 --- a/drivers/clk/sunxi-ng/ccu_nkm.c +++ b/drivers/clk/sunxi-ng/ccu_nkm.c@@ -128,6 +128,9 @@ static unsigned long ccu_nkm_round_rate(struct ccu_mux_internal *mux, if (rate < nkm->min_rate) return nkm->min_rate; + if (nkm->max_rate && rate > nkm->max_rate) + return nkm->max_rate; +
I would expect the test to be the same for the minimum and maximum cases. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Attachments
- signature.asc [application/pgp-signature] 228 bytes