Thread (16 messages) 16 messages, 4 authors, 2018-12-07

Re: [PATCH v2 5/7] pinctrl: qcom: spmi-gpio: fix gpio-hog related boot issues

From: Brian Masney <hidden>
Date: 2018-11-09 10:22:16
Also in: linux-arm-msm, linux-gpio, linux-pm, lkml

On Fri, Nov 09, 2018 at 09:59:08AM +0100, Linus Walleij wrote:
On Thu, Nov 1, 2018 at 1:12 AM Brian Masney [off-list ref] wrote:
quoted
When attempting to setup up a gpio hog, device probing would repeatedly
fail with -EPROBE_DEFERED errors. It was caused by a circular dependency
between the gpio and pinctrl frameworks. If the gpio-ranges property is
present in device tree, then the gpio framework will handle the gpio pin
registration and eliminate the circular dependency.

See Christian Lamparter's commit a86caa9ba5d7 ("pinctrl: msm: fix
gpio-hog related boot issues") for a detailed commit message that
explains the issue in much more detail. The code comment in this commit
came from Christian's commit.

Signed-off-by: Brian Masney <redacted>
No word from Bjorn but I trust my own intuition and applied it.

Björn: shout if it's wrong.

Question: should this also be done for pinctrl-ssbi-gpio.c?
Yes, I believe so.

Brian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help