Re: [PATCH 2/6] regulator: lochnagar: Move driver to binding from DT

On Thu, Nov 08, 2018 at 12:16:29PM +0000, Mark Brown wrote:

On Thu, Nov 08, 2018 at 10:14:01AM +0000, Charles Keepax wrote:

quoted

+static const struct of_device_id lochnagar_of_match[] = {
+	{ .compatible = "cirrus,lochnagar-regulator" },
+	{},
+};

This is obviously just dumping the Linux driver model into the DT, the
regulators are clearly different.  If you want to explicitly list the
regulators in DT it'd be better to reflect the hardware and enumerate
the regulators individually - you can use one driver for all the MICVDDs
and a separate one for VDDCORE for example.

Agreed, would be relatively doable for regulators, might be a bit
verbose for the clock, but I really don't see how to handle
pinctrl.

I guess I will wait and see what the other maintainers think but
personally I would really be inclined to keep the binding the
same as the last version if we can.

Thanks,
Charles