On Wed, 2018-09-19 at 15:39 +0800, andy.tang@nxp.com wrote:

+clockgen: global-utilities@e1000 {
+	compatible = "fsl,qoriq-clockgen";

Where does this compatible string come from?

+		compatible = "fsl,t1023-clockgen";
 	};

And here you overwrite it with only the chip-specific compatible?

Is t1023 incompatible with both fsl,qoriq-clockgen-1.0 and fsl,qoriq-clockgen-
2.0?  The existing dts says 2.0; is that wrong?

BTW, assuming it is 2.0 compatible and thus the use of qoriq-clockgen2.dtsi is
correct, the best course of action is probably to to remove the legacy stuff
from all fsl chips, rather than introduce a new dtsi.  In fact it'd be nice to
see it all removed in any case. :-)

Also, please post any patches that you want me to apply to the linuxppc-dev
mailing list.

-Scott