Re: [PATCH v2 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups
From: Schrempf Frieder <hidden>
Date: 2018-10-22 23:21:01
Also in:
linux-usb
On 22.10.18 07:43, Peter Chen wrote:
quoted hunk ↗ jump to hunk
For USB HSIC, the data and strobe pin needs to be pulled down at default, we consider it as "idle" state. When the USB host is ready to be used, the strobe pin needs to be pulled up, we consider it as "active" state. Signed-off-by: Peter Chen <redacted> --- Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 + 1 file changed, 1 insertion(+)diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt index 529e51879fb2..10c8d793ea49 100644 --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt@@ -81,6 +81,7 @@ Optional properties: mux state of 1 indicates host mode. - mux-control-names: Shall be "usb_switch" if mux-controls is specified. - pinctrl-names: Names for optional pin modes in "default", "host", "device" + Or names for HSIC "idle" and "active" pin modes.
I think you forgot to improve this description. Maybe something like this:
pinctrl-names: Names for optional pin modes for "default", "host" or
"device". In case of HSIC-mode "idle" and "active" pin
modes are mandatory. In this case the "idle" state needs
to pull down the data and strobe pin and the "active"
state needs to pull up the strobe pin.
Thanks,
Frieder
- pinctrl-n: alternate pin modes i.mx specific properties