Thread (21 messages) 21 messages, 4 authors, 2018-10-18

RE: [PATCH 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups

From: Peter Chen <hidden>
Date: 2018-10-17 08:57:20
Also in: linux-usb

 
On Tue, Oct 16, 2018 at 2:02 AM Peter Chen [off-list ref] wrote:
quoted
For USB HSIC, the data and strobe pin needs to be pulled down at
default, we consider it as "idle" state. When the USB host is ready to
be used, the strobe pin needs to be pulled up, we consider it as
"active" state.

Signed-off-by: Peter Chen <redacted>
---
 Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
 1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
index 529e51879fb2..10c8d793ea49 100644
--- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
+++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
@@ -81,6 +81,7 @@ Optional properties:
   mux state of 1 indicates host mode.
 - mux-control-names: Shall be "usb_switch" if mux-controls is specified.
 - pinctrl-names: Names for optional pin modes in "default", "host", "device"
+  Or names for HSIC "idle" and "active" pin modes.
I don't think this description is clear enough.

Could you please add a real dts snippet for the HSIC case instead?
Ok, I will add example like below at next version.
 usb@02184000 { /* USB OTG */ {
	...
                pinctrl-names = "idle", "active";
                pinctrl-0 = <&pinctrl_usbh2_1>;
                pinctrl-1 = <&pinctrl_usbh2_2>;
	...
};

Peter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help