Thread (15 messages) 15 messages, 6 authors, 2018-10-18

RE: [PATCH V2 2/4] arm64: dts: imx: add imx8qxp support

From: "A.s. Dong" <aisheng.dong@nxp.com>
Date: 2018-10-18 02:32:49
Also in: linux-arm-kernel

[...]
quoted
quoted
quoted
+               imx8qx-pm {
+                       compatible = "fsl,scu-pd";
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+
+                       pd_lsio: lsio-power-domain {
+                               #power-domain-cells = <0>;
+                               #address-cells = <1>;
+                               #size-cells = <0>;
+
+                               pd_lsio_pwm0: lsio-pwm0@191 {
+                                       reg = <191>;
The number after @ is in hex, so the reg property should be 0x191.
Thanks for the reminder.
The PD ID is defined in DEC. So I will change them all into HEX later manually.

BTW, this seems like error prone and checkpatch can't report it.
checkpatch doesn't really check dts files.

But if it did would you have noticed? Because there is at least one checkpatch
issue with your author name and S-o-b name not matching.
quoted
And I notice many similar users in kernel with the same issue:
arch/arm/boot/dts/tps65910.dtsi
arch/arm/boot/dts/tegra124-nyan.dtsi
arch/arm/boot/dts/rk3288.dtsi
At least I2C and SPI are now checked by dtc. 'simple-bus' children were too,
but silently broke and only recently got fixed in upstream dtc.
I've not pulled that into the kernel yet, but you can build dtbs using an external
copy of dtc. And guess what, there are *lots* of warnings.
Thanks for the info. Will try it.

Regards
Dong Aisheng
Rob
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help