On Sat, Oct 20, 2018 at 11:27:33AM +0200, Johan Hovold wrote:

On Fri, Oct 19, 2018 at 10:57:28AM +0200, Lars Poeschel wrote:

quoted

On Thu, Oct 18, 2018 at 05:00:28PM +0200, Marcel Holtmann wrote:

quoted

quoted

quoted

--- a/drivers/nfc/pn533/Kconfig
+++ b/drivers/nfc/pn533/Kconfig

@@ -25,3 +25,13 @@ config NFC_PN533_I2C

	  If you choose to build a module, it'll be called pn533_i2c.
	  Say N if unsure.
+
+config NFC_PN532_UART
+	tristate "NFC PN532 device support (UART)”

you are missing the "depends on SERIAL_DEV_BUS” here.

Yes, absolutely right. I missed that. I will post a follow-up.

BTW a question:
Only enabling SERIAL_DEV_BUS did not suffice for me. I also had to
enable SERIAL_DEV_CTRL_TTYPORT, otherwise the probe of the driver was
not called. This seems a bit odd to me. This option seems unrelated, but
without it, it did not work.

Should I better depend on SERIAL_DEV_CTRL_TTYPORT then ?

No, SERIAL_DEV_BUS is the correct (build-time) dependency.

In principle, your driver will work with any serdev-controller
implementation even if we currently only have one of those in the kernel
(and SERIAL_DEV_CTRL_TTYPORT therefore default to Y whenever
SERIAL_DEV_BUS is selected).

Thanks, this makes sense for me now.
I will post a follow-up patchset shortly.

Regards,
Lars