Thread (65 messages) 65 messages, 4 authors, 2018-10-25

Re: [PATCH V9 14/21] csky: User access

From: Arnd Bergmann <arnd@arndb.de>
Date: 2018-10-17 15:37:57
Also in: linux-arch, lkml

On Tue, Oct 16, 2018 at 5:05 AM Guo Ren [off-list ref] wrote:
The patch adds "user access from kernel" codes.

Signed-off-by: Guo Ren <redacted>
Cc: Arnd Bergmann <arnd@arndb.de>
---
 arch/csky/include/asm/uaccess.h | 416 ++++++++++++++++++++++++++++++++++++++++
 arch/csky/lib/usercopy.c        | 262 +++++++++++++++++++++++++
 2 files changed, 678 insertions(+)
 create mode 100644 arch/csky/include/asm/uaccess.h
 create mode 100644 arch/csky/lib/usercopy.c
Reviewed-by: Arnd Bergmann <arnd@arndb.de>

The 64-bit __put_user() is usually what everyone gets wrong, but
your version seems fine. Also the access_ok() checks and
the copy_to_user() result value all look correct.

        Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help