Thread (40 messages) 40 messages, 6 authors, 2018-11-01

Re: [PATCH v2 3/5] clk: lochnagar: Add support for the Cirrus Logic Lochnagar

From: Mark Brown <broonie@kernel.org>
Date: 2018-10-12 16:52:50
Also in: linux-clk, linux-gpio, lkml

On Thu, Oct 11, 2018 at 12:36:22PM -0700, Stephen Boyd wrote:
Quoting Mark Brown (2018-10-11 07:54:22)
quoted
On Thu, Oct 11, 2018 at 12:00:46AM -0700, Stephen Boyd wrote:
quoted
quoted
Is this used for anything besides getting the regmap? Can you get the
pointer to the parent in probe and use that to get the regmap pointer
from dev_get_remap() and also use the of_node of the parent to register
quoted
dev_get_regmap() is pretty expensive, I'd not advise using it in
anything that might approximate a fast path.  It's kind of debatable
when I2C gets involved but still feels wrong.
I'm suggesting the regmap is acquired in probe and a pointer is stored
here in this structure. That is not a fastpath as far as I know.
Ah, great - that's the intended usage.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help