Thread (13 messages) 13 messages, 6 authors, 2018-10-10

Re: [PATCH v3 1/2] Driver core: add bus_find_device_by_fwnode

From: Wolfram Sang <hidden>
Date: 2018-10-09 11:02:19
Also in: linux-arm-kernel, linux-i2c, linux-rdma, linux-spi, lkml, netdev

On Tue, Oct 09, 2018 at 03:47:24PM +0530, Silesh C V wrote:
Some drivers need to find the device on a bus having a specific firmware
node. Currently, such drivers have their own implementations to do this.
Provide a helper similar to bus_find_device_by_name so that each driver
does not have to reinvent this.

Signed-off-by: Silesh C V <redacted>
Looks good in general, however:

We recently had this discussion in I2C world about using the parent if
the (logical) device has a NULL fw_node [1]. I don't know if the other
subsystems you modify use logical devices as well? If no, it seems we
need an additional check for the parent in the I2C core only. If yes,
this might be considered in your patchset?

Thanks,

   Wolfram

[1] http://patchwork.ozlabs.org/patch/974584/

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help