Hi Chris,

On Mon, Sep 10, 2018 at 4:16 PM Chris Brandt [off-list ref] wrote:

On Monday, September 10, 2018 1, Geert Uytterhoeven wrote:

quoted

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in clk-renesas-for-v4.20.

Thank you!

Now that I have a clock, I can go ahead and submit a Device Tree.
However, I still don't have a solution for my OSTM timer driver when
using this new clock driver architecture.

Should I remove the ostm entries in r7s9210_mod_clks[] before you queue
it up?????

I see no issue with converting the OSTM driver to a platform driver (assumed
it works for you ;-)

quoted

One possible area for improvement is removing the unused entries in the
module clocks part of the priv->clks[] array:

+       .num_hw_mod_clks = 11 * 32, /* includes STBCR0 which doesn't exist
*/

Due to having 8-bit instead of 32-bit registers, 11 * 24 entries are not
used.
Fixing that means adding more checks in several functions, though, so I
don't know if you want to go that far...

That's basically why I didn't touch it. I didn't see any big benefit
from a system resource point of view.

OK, so you are aware of it.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds