Hello Simon,

Thank you for your feedback.

-----Original Message-----
From: Simon Horman <horms@verge.net.au>
Sent: 24 September 2018 10:14
To: Fabrizio Castro <redacted>
Cc: Ulf Hansson <redacted>; Rob Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Laurent
Pinchart [off-list ref]; Geert Uytterhoeven [off-list ref]; Linus Walleij
[off-list ref]; Wolfram Sang [off-list ref]; Magnus Damm [off-list ref];
linux-mmc@vger.kernel.org; devicetree@vger.kernel.org; linux-renesas-soc@vger.kernel.org; linux-gpio@vger.kernel.org; Chris
Paterson [off-list ref]; Biju Das [off-list ref]
Subject: Re: [PATCH 4/4] ARM: dts: iwg23s-sbc: Add uSD card support

On Fri, Sep 21, 2018 at 12:55:11PM +0100, Fabrizio Castro wrote:

quoted

Add uSD card support to the iwg23s single board computer powered
by the RZ/G1C SoC (a.k.a. r8a77470).

Signed-off-by: Fabrizio Castro <redacted>
Reviewed-by: Biju Das <redacted>
---
Hello Simon,

this patch can only be taken after patch "pinctrl: sh-pfc: r8a77470:
Add SDHI2 voltage switch" from this series appears on a release candidate
or a release.

What is the nature of that dependency. Does adding this patch without
its dependency cause a regression?

Since the SDHI2 pins definition contain "power-source" property, adding this
patch without its dependency will cause an error at boot up as the kernel
would be looking for flag SH_PFC_PIN_CFG_IO_VOLTAGE for each pin contained
in sdhi2_pins and sdhi2_pins_uhs, and since that particular flag would be missing
(as such a definition comes from patch "pinctrl: sh-pfc: r8a77470: Add SDHI2 voltage
switch") the SD card would not be functional, but this won't have any impact on
the rest of the system.

quoted

Shall I re-send it at a later stage or are you happy to keep it around
and defer its application to when its dependency is sorted?

I'd rather that you repost or otherwise ping me once any dependency is sorted.

Ok, I will do that.

Thanks,
Fab



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.