Thread (5 messages) 5 messages, 2 authors, 2018-09-27

Re: [PATCH v7 2/2] hwmon: ina3221: Read channel input source info from DT

From: Nicolin Chen <nicoleotsuka@gmail.com>
Date: 2018-09-27 22:11:20
Also in: linux-doc, linux-hwmon, lkml

On Thu, Sep 27, 2018 at 03:06:20PM -0700, Guenter Roeck wrote:
 
I am quite sure I asked to use kstrtobool(). Did that get lost or do you have
some reason to not use it ?

I can understand if you don't want to change ina3221_is_enable() to
ina3221_is_enabled(), since that is POV, but I don't really understand
why you did not make the other changes. Am I missing something ?
Sorry, my fault. It's not really "I don't want to" but I missed the
part in that review. Will fix them all.

Thanks
Nicolin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help