Thread (10 messages) 10 messages, 2 authors, 2018-09-21

Re: [PATCH 2/2] hwmon: ina3221: Get channel names from DT node

From: Nicolin Chen <nicoleotsuka@gmail.com>
Date: 2018-09-21 17:44:03
Also in: linux-hwmon, lkml

On Fri, Sep 21, 2018 at 05:56:00AM -0700, Guenter Roeck wrote:
quoted
I tried is_visible but it looks like it won't be that neat to
implement as some attributes of this driver don't really pass
the channel index to the store()/show() but some other indexes.
The channel index is not the only means that can be used to determine
the channel index. Many drivers use the position in the attrs[] array
to determine the channel index. I don't see why this would not be
possible here.
Hmmm, that should simply work...I didn't mean not possible though.
quoted
If you are very against the dynamical group, I can drop it to
leave the sysfs node as it was.

And for the name nodes that I was talking about above, I will
add an sysfs store() function so non-DT users can set them,
and I also removed the confusing "unknown" default name.
The label attributes are RO. Please follow the ABI.

temp[1-*]_label Suggested temperature channel label.
Thanks a lot for the hint. I looked up the doc and feel that
this one probably fits my situation more:
    in[0-*]_label   Suggested voltage channel label.

Will follow it in my next version.

Thank you
Nicolin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help