Thread (15 messages) 15 messages, 4 authors, 2018-09-18

Re: [PATCH v3 1/5] drm/rockchip: prepare common code for cdns and rk dpi/dp driver

From: Andrzej Hajda <hidden>
Date: 2018-09-13 10:01:07
Also in: dri-devel, linux-arm-kernel, linux-rockchip, lkml

Hi Damian,

Quite late but.

On 28.08.2018 12:24, Damian Kos wrote:
- Extracted common fields from cdn_dp_device to a new cdns_mhdp_device
  structure which will be used by two separate drivers later on.
- Moved some datatypes (audio_format, audio_info, vic_pxl_encoding_format,
  video_info) from cdn-dp-core.c to cdn-dp-reg.h.
- Changed prefixes from cdn_dp to cdns_mhdp
    cdn -> cdns to match the other Cadence's drivers
    dp -> mhdp to distinguish it from a "just a DP" as the IP underneath
      this registers map can be a HDMI (which is internally different,
      but the interface for commands, events is pretty much the same).
- Modified cdn-dp-core.c to use the new driver structure and new function
  names.

Signed-off-by: Damian Kos <redacted>
Many changes, hard to review. Anyway:

Reviewed-by: Andrzej Hajda <redacted>

 --
Regards
Andrzej
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help