Re: [PATCH v2 10/11] arm64: dts: qcom: Add reg-names for all tsens nodes
From: Bjorn Andersson <hidden>
Date: 2018-09-03 20:30:15
Also in:
linux-arm-msm, lkml
On Tue 28 Aug 06:38 PDT 2018, Amit Kucheria wrote:
quoted hunk ↗ jump to hunk
Instead of showing up as thermal-sensor@<addr>, the nodes will show up as tsens0_tm, tsen1_tm, tsens1_srot, etc. in /proc/iomem making it easier to read. IOW, 0c222000-0c2221fe : thermal-sensor@c263000 0c223000-0c2231fe : thermal-sensor@c265000 0c263000-0c2631fe : thermal-sensor@c263000 0c265000-0c2651fe : thermal-sensor@c265000 becomes 0c222000-0c2221fe : tsens0_srot 0c223000-0c2231fe : tsens1_srot 0c263000-0c2631fe : tsens0_tm 0c265000-0c2651fe : tsens1_tm Signed-off-by: Amit Kucheria <redacted> Reviewed-by: Matthias Kaehlcke <mka@chromium.org> --- arch/arm/boot/dts/qcom-msm8974.dtsi | 1 + arch/arm64/boot/dts/qcom/msm8916.dtsi | 1 + arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 ++ arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 ++ 4 files changed, 6 insertions(+)diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi index 3c4b81c29798..64c9f81ddd90 100644 --- a/arch/arm/boot/dts/qcom-msm8974.dtsi +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi@@ -431,6 +431,7 @@ compatible = "qcom,msm8974-tsens"; reg = <0xfc4a9000 0x1000>, /* TM */ <0xfc4a8000 0x1000>; /* SROT */ + reg-names = "tsens_tm", "tsens_srot";
While the iomem output seems more convenient this way, these register names are a contract between the DT binding and the particular tsens instance. As such this is a good idea, but with the names should not include the instance information. They should be "tm", "srot".
nvmem-cells = <&tsens_calib>, <&tsens_backup>; nvmem-cell-names = "calib", "calib_backup"; #qcom,sensors = <11>;
[..]
quoted hunk ↗ jump to hunk
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 0c9a2aa6a1b5..f1a36d6829cf 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi@@ -966,6 +966,7 @@ compatible = "qcom,sdm845-tsens", "qcom,tsens-v2"; reg = <0xc263000 0x1ff>, /* TM */ <0xc222000 0x1ff>; /* SROT */ + reg-names = "tsens0_tm", "tsens0_srot"; #qcom,sensors = <13>; #thermal-sensor-cells = <1>; };@@ -974,6 +975,7 @@ compatible = "qcom,sdm845-tsens", "qcom,tsens-v2"; reg = <0xc265000 0x1ff>, /* TM */ <0xc223000 0x1ff>; /* SROT */ + reg-names = "tsens1_tm", "tsens1_srot";
And I do recognize that in this case iomem won't show which one is tsens0 and which is tsens1... As with previous patches, please split arm and arm64 in separate patches. Regards, Bjorn