Re: [PATCH 03/14] mmc: mmci: internalize dma_inprogress into mmci dma functions
From: Ulf Hansson <hidden>
Date: 2018-09-03 12:15:11
Also in:
linux-arm-kernel, linux-mmc, lkml
On 1 August 2018 at 11:36, Ludovic Barre [off-list ref] wrote:
From: Ludovic Barre <redacted> This patch internalizes the dma_inprogress into mmci dma interfaces. This allows to simplify and prepare the next dma callbacks for mmci host ops. __dma_inprogress is called in mmci_dma_data_error and mmci_dma_finalize. Signed-off-by: Ludovic Barre <redacted>
[...]
quoted hunk ↗ jump to hunk
diff --git a/drivers/mmc/host/mmci.h b/drivers/mmc/host/mmci.h index 696a066..f1ec066 100644 --- a/drivers/mmc/host/mmci.h +++ b/drivers/mmc/host/mmci.h@@ -332,9 +332,7 @@ struct mmci_host { struct mmci_host_next next_data; bool dma_in_progress; -#define dma_inprogress(host) ((host)->dma_in_progress) -#else -#define dma_inprogress(host) (0) +#define __dma_inprogress(host) ((host)->dma_in_progress)
Please keep the existing function name. If there are good reasons to change it, please make it a part of a change where it makes sense.
#endif }; -- 2.7.4
Besides the nitpick above, this looks good to me! Kind regards Uffe