Thread (7 messages) 7 messages, 3 authors, 2018-08-02

Re: [PATCH] spi: pl022: Add OF binding to disable DMA usage

From: Alexander Sverdlin <hidden>
Date: 2018-08-01 12:33:23

Hello Mark,

On 01/08/18 12:39, Mark Brown wrote:
quoted
quoted
this or if we shouldn't instead be looking at improving the driver to
work better in systems with limited channels, for example by only
claiming the channels when it's active (since it can fall back to PIO if
it doesn't get them).  That might be too heavyweight though, possibly
yes, this is an option as well, but at the time we need to take this decision
the bus scan has not yet been performed. We could scan all the devices in
the DT and check if any of them requires DMA. This would mean, that
probe() of the PL022 driver will include similar code to the bus scan
that anyway will happen later just to take the decision on DMA usage.
But I'm fine with that. If this sounds better than new boolean DT binding,
I'll send another patch.
I'm not 100% clear I follow what you mean by bus scan here but I *think*
that sounds about right.  The channel request/release could be factored
out into helper functions to minimize duplication.
Rob has an opinion that the driver should only claim the channels explicitly
specified in DT. This sounds about right, but this would be behavioral change.
What do you think?

-- 
Best regards,
Alexander Sverdlin.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help