Thread (25 messages) 25 messages, 8 authors, 2018-09-11

Re: v4.17 regression: PowerMac G3 won't boot, was Re: [PATCH v5 1/3] of: cache phandle nodes to reduce cost of of_find_node_by_phandle()

From: Mac User <hidden>
Date: 2018-08-31 02:39:44
Also in: linuxppc-dev

On 8/29/18 7:05 PM, Rob Herring wrote:
On Wed, Aug 29, 2018 at 7:44 PM Finn Thain [off-list ref] wrote:
quoted
Hi Frank,

Linux v4.17 and later will no longer boot on a G3 PowerMac. The boot hangs
very early, before any video driver loads.

Stan and I were able to bisect the regression between v4.16 and v4.17 and
arrived at commit 0b3ce78e90fc ("of: cache phandle nodes to reduce cost of
of_find_node_by_phandle()").

I don't see any obvious bug in 0b3ce78e90fc or b9952b5218ad. But if you
revert these from v4.18 (which is also affected) that certainly resolves
the issue.
Perhaps a bad assumption on phandle values causing a problem. Can you
provide a dump of all the phandle or linux,phandle values from
/proc/device-tree.

Rob
Rob,

As suggested by Finn, I installed device-tree-compiler and
powerpc-ibm-utils.
 
Running "dtc -I fs -H both /sys/firmware/devicetree/base"
resulted in the following errors:

DTC: fs->dts on file "/sys/firmware/devicetree/base"
ERROR (name_properties): "name" property in
/pci/multifunc-device/pci1799,1#1 is incorrect ("pci1799,1" instead of
base node name)
ERROR (name_properties): "name" property in /pci/mac-io/ide#1 is
incorrect ("ide" instead of base node name)
ERROR (name_properties): "name" property in
/pci/mac-io/ide#1/atapi-disk#1 is incorrect ("atapi-disk" instead of
base node name)
ERROR (name_properties): "name" property in /cpus/PowerPC,750/l2-cache#1
is incorrect ("l2-cache" instead of base node name)
ERROR: Input tree has errors, aborting (use -f to force output)

If I force output with "-f", the resulting file has no occurrences 
of "phandle".

Running "lsprop /proc/device-tree | grep -i phandle" results in no 
output.

Please let me know if there's some other way to get information that 
would be helpful.

thanks

-Stan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help