Thread (15 messages) 15 messages, 6 authors, 2018-08-07

Re: [PATCH] mtd: spi-nor: only apply reset hacks to broken hardware

From: Rob Herring <robh@kernel.org>
Date: 2018-08-07 18:39:01

On Tue, Jul 31, 2018 at 03:35:50PM -0700, Brian Norris wrote:
Hi Neil, Boris,

On Tue, Jul 31, 2018 at 10:12:55PM +0200, Boris Brezillon wrote:
quoted
On Tue, 31 Jul 2018 11:05:11 +1000
NeilBrown [off-list ref] wrote:
quoted
On Fri, Jul 27 2018, Boris Brezillon wrote:
quoted
On Fri, 27 Jul 2018 11:33:13 -0700
I'll leave Neil some time to review/test/comment on the patch before
queuing it, but it looks good to me.  
Thanks.
I can confirm that if I apply this patch, my system won't reboot
properly (as expected), and if I then add

		broken-flash-reset;

to the jedec,spi-nor device, it starts functioning correctly again.

I don't like the pejorative "broken", and it also suggests that a thing
used to work, but something happened to break it - this is not
accurate.
I would prefer something like "reset-not-connected" which is an accurate
description of the state of the hardware.
One reason I didn't specifically say something like "not connected", is
because IIUC it's actually *possible* to have a robust boot sequence
without the RESET# pin -- e.g., if your boot ROM hardcoded a software
reset command (just because it's not really standardized doesn't mean
one can't do it).
Based on that, then it sounds like you need a specific compatible string 
so you too can know how to s/w reset the device.

I guess you are assuming a bootloader didn't leave the flash in an 
unknown addressing state?

Rob


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help